Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass name of the block to render_callback #9953

Closed
wants to merge 1 commit into from

Conversation

abolfazl-moeini
Copy link

Key/name of the block type is required when parsing multiple blocks with the same render callback,
also when WordPress fire shortcode callback, pass shortcode tag as third parameter and the render_callback should be similar.

@Soean Soean added [Package] Server Side Render /packages/server-side-render and removed [Package] Server Side Render /packages/server-side-render labels Oct 15, 2018
@gziolo
Copy link
Member

gziolo commented Jan 25, 2019

This patch should be moved to WordPress core’s track as it is maintained there since WordPress 5.0 release:
https://core.trac.wordpress.org/

This file is going to be removed from Gutenberg plugin in the next release.

Thank you for your contribution! I’m closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants